Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: replace NoArrayBufferZeroFillScope with v8 option #56658

Closed
wants to merge 1 commit into from
Closed

src: replace NoArrayBufferZeroFillScope with v8 option #56658

wants to merge 1 commit into from
+41 −44

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Jan 19, 2025 •
edited
Loading

NoArrayBufferZeroFillScope was added before the v8 option to create uninitialized backing stores was added. We can start moving away from it.

There are a handful of remaining instances in src/crypto that I remove in a separate PR. Once both of these land we can remove the NoArrayBufferZeroFillScope class entirely.

@jasnell jasnell requested review from anonrig and aduh95 January 19, 2025 15:45
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/http2
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jan 19, 2025
@jasnell jasnell added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 19, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 19, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 96.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.22%. Comparing base (905e4b4) to head (db9587c).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
src/node_buffer.cc 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #56658   +/-   ##
=======================================
  Coverage   89.21%   89.22%           
=======================================
  Files         662      662           
  Lines      191948   191941    -7     
  Branches    36941    36945    +4     
=======================================
+ Hits       171241   171250    +9     
+ Misses      13552    13545    -7     
+ Partials     7155     7146    -9
Files with missing lines Coverage Δ
src/encoding_binding.cc 79.09% <100.00%> (ø)
src/env.cc 85.96% <100.00%> (+0.01%) ⬆️
src/node_http2.cc 85.11% <100.00%> (+0.20%) ⬆️
src/stream_base.cc 80.33% <100.00%> (-0.04%) ⬇️
src/node_buffer.cc 70.00% <85.71%> (-0.27%) ⬇️

... and 25 files with indirect coverage changes

@jasnell jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 19, 2025
mcollina
mcollina approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 21, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@jasnell
Copy link
Member Author

jasnell commented Jan 23, 2025

@nodejs/platform-smartos ... getting a flaky failure here: https://ci.nodejs.org/job/node-test-commit-smartos/58751/

@mcollina
Copy link
Member

@jasnell I think there might be some related failures. Specifically a test fails on ARM and Windows, with the same error:

https://ci.nodejs.org/job/node-test-binary-windows-js-suites/32184/RUN_SUBSET=2,nodes=win11-COMPILED_BY-vs2022/testReport/junit/(root)/parallel/test_fs_cp/

  AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
  + actual - expected

  + 'ERR_FS_EISDIR'
  - 'ERR_FS_CP_EINVAL'
            ^

      at file:///c:/workspace/node-test-binary-windows-js-suites/node/test/parallel/test-fs-cp.mjs:687:12

@nodejs/platform-smartos there seem to be some potential infra issue (or possibly it's a problem with this change) - tests are not actually run here.

@jasnell
src: replace NoArrayBufferZeroFillScope with v8 option
db9587c 
NoArrayBufferZeroFillScope was added before the v8 option to
create uninitialized backing stores was added. We can start
moving away from it.
@jasnell jasnell force-pushed the use-v8-option-for-no-zero-fill branch from 78e5b98 to db9587c Compare January 23, 2025 15:44
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 23, 2025 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/64656/ 💛

jasnell added a commit that referenced this pull request Jan 23, 2025
@jasnell
src: replace NoArrayBufferZeroFillScope with v8 option
869ea33 
NoArrayBufferZeroFillScope was added before the v8 option to
create uninitialized backing stores was added. We can start
moving away from it.

PR-URL: #56658
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
@jasnell
Copy link
Member Author

jasnell commented Jan 23, 2025

Landed in 869ea33

@jasnell jasnell closed this Jan 23, 2025
aduh95 pushed a commit that referenced this pull request Jan 27, 2025
@jasnell @aduh95
src: replace NoArrayBufferZeroFillScope with v8 option
0d28b6c 
NoArrayBufferZeroFillScope was added before the v8 option to
create uninitialized backing stores was added. We can start
moving away from it.

PR-URL: #56658
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
@github-actions github-actions bot mentioned this pull request Jan 28, 2025
Merged
aduh95 pushed a commit that referenced this pull request Jan 30, 2025
@jasnell @aduh95
src: replace NoArrayBufferZeroFillScope with v8 option
2b6a82d 
NoArrayBufferZeroFillScope was added before the v8 option to
create uninitialized backing stores was added. We can start
moving away from it.

PR-URL: #56658
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
@anonrig
Copy link
Member

anonrig commented Jan 31, 2025

@nodejs/platform-smartos ... getting a flaky failure here: https://ci.nodejs.org/job/node-test-commit-smartos/58751/

@jasnell did you create a flaky test report for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@legendecas legendecas legendecas approved these changes

@targos targos targos approved these changes

@anonrig anonrig anonrig approved these changes

@mcollina mcollina mcollina approved these changes

@aduh95 aduh95 Awaiting requested review from aduh95

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jasnell @nodejs-github-bot @mcollina @anonrig @targos @legendecas @RafaelGSS